Actually adjust copy button logic to new API #8554
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
Remove the obsolete textarea creation and correctly handle other permission errors
HTMLUnit now supports `isSecureContext`
NotMyFault
added
the
needs-security-review
yaroslavafenkin
added
security-approved
HTMLUnit 3 should already be implemented in all the plugins that are included in the bill of materials, but it is better to verify in the plugin bill of materials now than to discover it with a broken build of the plugin BOM at release time. Checking * jenkinsci/jenkins#8554 Thanks to @D3SOX for the pull request proposing the improvement.
|
Thanks very much @D3SOX . I've submitted a verification test with the plugin bill of materials to confirm that this improvement does not surprise us in the bill of materials release. Pull request is: |
|
/label ready-for-merge This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback. Thanks! |
comment-ops-bot
bot
added
the
ready-for-merge
|
Congratulations on getting your very first Jenkins core pull request merged 🎉🥳 |
| @@ -4,31 +4,20 @@ Behaviour.specify( | |||
| 0, | |||
| function (copyButton) { | |||
| copyButton.addEventListener("click", () => { | |||
| // HTMLUnit 2.70.0 does not recognize isSecureContext | |||
There was a problem hiding this comment.
introduced in #7784 FTR; see HtmlUnit/htmlunit@54d9d30
| hoverNotification(copyButton.getAttribute("message"), copyButton); | ||
| if (isSecureContext) { | ||
| // Copy the text to the clipboard | ||
| navigator.clipboard |
There was a problem hiding this comment.
whilst mainstream browsers support this (according to canIUse) I believe unless you set a handler in HtmlUnit that navigator.clipboard will be undefined when running tests with webclient.
the webclient created in j-t-h is not configured with a handler.
The previous code (introduced in #6698) contained obsolete logic from the deprecated clipboard API, which was removed here.
The Promise returned by
navigator.clipboard.writeTextis now correctly handled as described per https://developer.mozilla.org/en-US/docs/Web/API/Clipboard/writeText#return_valueI've also removed the check if it's running as test as HTMLUnit 3.1.0 added support for
isSecureContextTesting done
I have overwritten the function with the console to always return a rejecting Promise. Therefore, the new logic is tested
Proposed changelog entries
I think this does not need to be mentioned in the changelog
Alternatives I have considered
We could implement the deprecated clipboard API again when we are not in a secure context
Additional testing done